Skip to content

2.x: add parallel hooks to RxJavaPlugins, add missing params validation #5043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2017
Merged

2.x: add parallel hooks to RxJavaPlugins, add missing params validation #5043

merged 1 commit into from
Feb 2, 2017

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Feb 1, 2017

This PR adds an onAssembly hook for ParallelFlowable operators and adds the missing parameter validation to some parallel operators.

@akarnokd akarnokd added this to the 2.1 milestone Feb 1, 2017
@codecov-io
Copy link

codecov-io commented Feb 1, 2017

Codecov Report

Merging #5043 into 2.x will increase coverage by <.01%.

@@             Coverage Diff              @@
##                2.x    #5043      +/-   ##
============================================
+ Coverage     95.63%   95.63%   +<.01%     
- Complexity     5539     5542       +3     
============================================
  Files           612      612              
  Lines         39545    39576      +31     
  Branches       5551     5553       +2     
============================================
+ Hits          37817    37850      +33     
+ Misses          748      747       -1     
+ Partials        980      979       -1
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/plugins/RxJavaPlugins.java 100% <100%> (+0.72%) 138 <5> (+5) ✅
...n/java/io/reactivex/parallel/ParallelFlowable.java 100% <100%> (ø) 41 <16> (ø) ❌
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <ø> (-4.62%) 27% <ø> (-1%)
...ava/io/reactivex/processors/BehaviorProcessor.java 86.44% <ø> (-4.21%) 55% <ø> (+1%)
...internal/operators/completable/CompletableAmb.java 94.44% <ø> (-3.71%) 10% <ø> (-1%)
.../main/java/io/reactivex/subjects/MaybeSubject.java 97.82% <ø> (-2.18%) 47% <ø> (-1%)
...rnal/operators/observable/ObservableObserveOn.java 97.94% <ø> (-2.06%) 3% <ø> (ø)
.../internal/operators/maybe/MaybeTakeUntilMaybe.java 97.95% <ø> (-2.05%) 2% <ø> (ø)
...nternal/operators/observable/ObservableCreate.java 97.32% <ø> (-1.79%) 2% <ø> (ø)
...n/java/io/reactivex/processors/AsyncProcessor.java 97.45% <ø> (-1.7%) 55% <ø> (-1%)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceded86...4dfc07b. Read the comment docs.

@akarnokd akarnokd merged commit 1ea1291 into ReactiveX:2.x Feb 2, 2017
@akarnokd akarnokd deleted the ParallelFlowablePlugin branch February 2, 2017 08:16
@akarnokd akarnokd mentioned this pull request Feb 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JakeWharton JakeWharton JakeWharton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Enhancement

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@akarnokd @codecov-io @JakeWharton